Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update stable rust from 1.82 to 1.84 #88

Merged
merged 1 commit into from
Jan 13, 2025
Merged

feat: update stable rust from 1.82 to 1.84 #88

merged 1 commit into from
Jan 13, 2025

Conversation

antonbaliasnikov
Copy link
Contributor

@antonbaliasnikov antonbaliasnikov commented Jan 13, 2025 •
edited
Loading

Stable Rust toolchain updated from 1.82 to 1.84, update the docker image to reinstall Rust.

@hedgar2017
Copy link
Collaborator

Stable Rust toolchain updated from 1.82 to 1.84, update the docker image to reinstall Rust.

Will it be used everywhere now?
We should probably be careful. IIRC last time we had an issue with LLVM version used by newer Rust compilers.

PavelKopyl
PavelKopyl approved these changes Jan 13, 2025
View reviewed changes
Copy link

@PavelKopyl PavelKopyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonbaliasnikov
Copy link
Contributor Author

Stable Rust toolchain updated from 1.82 to 1.84, update the docker image to reinstall Rust.

Will it be used everywhere now? We should probably be careful. IIRC last time we had an issue with LLVM version used by newer Rust compilers.

Yeah, I'll test it from main before updating latest tag.

@antonbaliasnikov antonbaliasnikov merged commit f3100d4 into main Jan 13, 2025
2 checks passed
@antonbaliasnikov antonbaliasnikov deleted the aba-update-rust-1.82-1.84 branch January 13, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelKopyl PavelKopyl PavelKopyl approved these changes

@hedgar2017 hedgar2017 hedgar2017 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antonbaliasnikov @hedgar2017 @PavelKopyl